Spiny Starfish’s first ability creates a regeneration shield for it. Spiny Starfish’s second ability checks whether it _used_ any regeneration shields that turn, not whether any regeneration shields were created for it.

The second ability doesn’t care where the regeneration shields Spiny Starfish used that turn came from. If it regenerated due to a regeneration shield from Refresh, for example, the ability will still put a Starfish token onto the battlefield.

The second ability has an “intervening ‘if’ clause,” so it won’t trigger at all unless Spiny Starfish had regenerated that turn. However, the number of tokens that are created isn’t determined until the ability resolves (in case it regenerates again before that time).

If Spiny Starfish regenerates during the end step after its second ability has resolved, no tokens will be created as a result.